Repository navigation
docs(shard): use neutral names for the example build lists - #49
Merged
Merged
Conversation
stack-shard.org showed --build-list Snel-2026e.list twice, and the shard tests and fixtures carried the same site's names: a "# Snel wave 1, rome" header in wave1.list, a "# Snel-2026 header" list in the jenkins tests, and --include-systems=snel-zen2 (or snel) on lines in the shard_sources, site_commands, stack_shard and stack_shard_sources tests and in opaque.list. CONTRIBUTING.md keeps site hostnames, paths and private names in the site target layer, out of the public files. The page now builds site-2026e.list, the header reads "# Wave 1, rome", and the --include-systems values are site-zen2 and site. The tests check the same behaviour, since those values pass through verbatim. FORBIDDEN in doc_walkthrough.rs gains "Snel", so a how-to bash block that names that site fails howto_bash_blocks_name_files_in_this_checkout. With that token the test fails on main.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shard how-to, tests and fixtures use neutral names (
site-2026e.list,site-zen2) instead of one site's token, and the walkthrough forbids that token.Snel-2026e.list, and the shard tests and fixtures carried the same site's names in list headers and in--include-systems.CONTRIBUTING.mdkeeps site hostnames, paths and private names in the site target layer, out of the public files. The page now buildssite-2026e.list, the header reads "# Wave 1, rome", and the--include-systemsvalues aresite-zen2andsite.FORBIDDENindoc_walkthrough.rsgainsSnel, so a how-to bash block that names that site failshowto_bash_blocks_name_files_in_this_checkout.The commit has a towncrier fragment. Main has no towncrier yet; #26 (
fix/towncrier) adds it.